Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no logic to let test pass if requireSameDimensions=false for backstop #99

Open
mrSingh007 opened this issue Jun 13, 2017 · 1 comment
Open

There is no logic to let test pass if requireSameDimensions=false for backstop #99

mrSingh007 opened this issue Jun 13, 2017 · 1 comment
Labels
Bug

Comments

@mrSingh007
Copy link

mrSingh007 commented Jun 13, 2017 •
edited

As in backstopJS there is one option which can be set to false to let test pass is content is same (RGBS) but just height/width if difference. I mean if mismatch is 0.
Please see this issue for deep details and solution. It would be nice if we could take my suggested solution.
I checked all "js" files but no where logic on it. (find -name "*.js" | xargs grep "requireSameDimensions" )
thanks.
garris/BackstopJS#456
@mrSingh007 mrSingh007 mentioned this issue Jun 13, 2017
Open
@jamescryer
Copy link
Member

I think the result when using diff.scaleToSameSize(); should reflect the original proportions. At the moment "dimensionDifference" will return no difference after scaling. With the suggested change you intelligently report on comparisons where there are differences in dimension, but no RGBA differences after scaling.

I'll mark as a bug, happy to accept and review a Pull Request.

@jamescryer jamescryer added the Bug label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamescryer @mrSingh007