Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring antialiasing does not work correctly #151

Open
DudaGod opened this issue Sep 5, 2018 · 6 comments
Open

Ignoring antialiasing does not work correctly #151

DudaGod opened this issue Sep 5, 2018 · 6 comments

Comments

@DudaGod
Copy link

DudaGod commented Sep 5, 2018

Hello guys.

How do you think these images are equivalent if you want to ignore antialiasing?

resemble js image analysis 2018-09-05 19-12-43

Expected behaviour:
comparison with tolerance 2.3 and with ignore antialiasing

@jamescryer
Copy link
Member

Apologies for the very late response. The ignore antialiasing mode is more tolerant of colour difference, in this case though I agree that it's a little too tolerant.

https://github.com/rsmbl/Resemble.js/blob/master/resemble.js#L879

It think its fair to say it should only use the increased tolerance mode on pixels identified as "anti-aliased" rather than all pixels. Any change in behaviour in this regard would probably require a major release.

@rodrigo-garcia-leon
Copy link

Hey, is this issue still relevant? and if so can I work on it? 🧐

@jamescryer
Copy link
Member

@rodrigo-garcia-leon Of course, although it may take me a while to review any changes.

@rodrigo-garcia-leon
Copy link

Excellent 👌

@rodrigo-garcia-leon
Copy link

Hi @jamescryer,

I've been reading the code to understand the issue and come up with possible solutions.
I have three ideas in mind:

  1. Lower the tolerance thresholds in https://github.com/rsmbl/Resemble.js/blob/master/resemble.js#L981
  2. Create an intermediate setting with different tolerance thresholds
  3. Allow the definition of the thresholds via the options object

Additionally, there's the improvement that you mentioned; use the increased tolerance mode only on pixels identified as "anti-aliased".

Not sure how to proceed, what do you think?

@asterium
Copy link

asterium commented Dec 3, 2019

Hi @rodrigo-garcia-leon,
It's offtopic for this specific bug, however option 3 mentioned will be very useful feature.
Please let me know if I should open separate issue in order to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants