New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring antialiasing does not work correctly #151
Comments
Apologies for the very late response. The ignore antialiasing mode is more tolerant of colour difference, in this case though I agree that it's a little too tolerant. https://github.com/rsmbl/Resemble.js/blob/master/resemble.js#L879 It think its fair to say it should only use the increased tolerance mode on pixels identified as "anti-aliased" rather than all pixels. Any change in behaviour in this regard would probably require a major release. |
Hey, is this issue still relevant? and if so can I work on it? 🧐 |
@rodrigo-garcia-leon Of course, although it may take me a while to review any changes. |
Excellent 👌 |
Hi @jamescryer, I've been reading the code to understand the issue and come up with possible solutions.
Additionally, there's the improvement that you mentioned; use the increased tolerance mode only on pixels identified as "anti-aliased". Not sure how to proceed, what do you think? |
Hi @rodrigo-garcia-leon, |
Hello guys.
How do you think these images are equivalent if you want to ignore antialiasing?
Expected behaviour:
comparison with tolerance 2.3 and with ignore antialiasing
The text was updated successfully, but these errors were encountered: